[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] vl.c: use 'break' instead of 'co

From: Peter Maydell
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] vl.c: use 'break' instead of 'continue' in configure_accelerator()
Date: Mon, 31 Mar 2014 14:01:21 +0100

On 31 March 2014 13:53, Chen Gang <address@hidden> wrote:
> On 03/31/2014 08:38 PM, Markus Armbruster wrote:
>> Chen Gang <address@hidden> writes:
>>> Hello Maintainers:
>>> If it is necessary to send patch v2 by me, please let me know, I
>>> will/should send.
>> Not a maintainer, but if you send a v2 with an improved commit message,
>> I'll R-by it, which can only help getting it merged.
> I guess your meaning is "not quite necessary" (for me, minor useful
> patches almost like spam). So if sending patch v2 is really required,
> please let me know, thanks.

Basically, asking a maintainer to make changes to a patch
as they apply it is asking them to do extra work beyond
what they would normally do. Sometimes people will agree
to do this, but in general it's better just to send a fixed
version of the patch yourself.

(I've cc'd qemu-trivial since that's probably the best tree
to take this patch.)

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]