[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] Drop superfluous conditionals ar

From: Eric Blake
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] Drop superfluous conditionals around g_strdup()
Date: Thu, 04 Dec 2014 12:17:32 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0

On 12/04/2014 03:39 AM, Markus Armbruster wrote:

> As per standard operating procedure, I expanded tabs in the lines I
> touched.  No visual difference, except in patches.
> What do you want me to do?
> 1. Don't expand tabs, ignore checkpatch.pl whining
> 2. Expand tabs in touched lines (current patch)
> 3. Expand all tabs in uri_resolve() (in a separate patch, of course)
> 4. Expand all tabs in util/uri.c (in a separate patch, of course)

My preferred choice first: 2, 4, 3, 1

That is, I'm fine with how you did it.  If you are going to clean up
tabs as a separate patch, I'd prefer you do it for the whole file rather
than just one function. And I'd rather a tab cleanup than ignoring
checkpatch.pl, but not at the expense of favoring a tab cleanup ahead of
the current proposed patch.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]