[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH 1/1] Do not hang on full PTY

From: Michael Tokarev
Subject: Re: [Qemu-trivial] [PATCH 1/1] Do not hang on full PTY
Date: Mon, 29 Dec 2014 12:59:02 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.3.0

22.12.2014 18:04, Don Slutz wrote:

> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -1387,6 +1387,7 @@ static CharDriverState *qemu_chr_open_pty(const char 
> *id,
>      }
>      close(slave_fd);
> +    qemu_set_nonblock(master_fd);
>      chr = qemu_chr_alloc();

Hm.  I'm not sure at all this is a trivial change.  While the
patch itself is trivial indeed, it changes behavour of the file
descriptor significantly.  Are all the places where this fd is
subsequently used prepared for it being non-blocking?  Oh well... ;)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]