[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH 00/11] trivial: Remove superfluou
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH 00/11] trivial: Remove superfluous '\n' around error_report/error_setg |
Date: |
Wed, 11 Feb 2015 14:41:04 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
<address@hidden> writes:
> From: Gonglei <address@hidden>
>
> Yestoday, I found that some files have superflous '\n' charactor
> around error_report/error_setg when reviewed patches.
>
> By a simply script, the below files were listed. Classify and fix
> them. It's suitable for appling via qemu-trivial IMHO.
You can find my script in commit 312fd5f :)
> Gonglei (11):
> block: remove superfluous '\n' around error_report/error_setg
> a9gtimer: remove superfluous '\n' around error_setg
> pl330.c: remove superfluous '\n' around error_setg
> numa: remove superfluous '\n' around error_setg
> Remove superfluous '\n' around error_report()
> vhost-scsi: Remove superfluous '\n' around error_report()
> vfio: Remove superfluous '\n' around error_report()
> xtensa: Remove superfluous '\n' around error_report()
> tpm: Remove superfluous '\n' around error_report()
> arm/digic_boards: Remove superfluous '\n' around error_report()
> vhost: Remove superfluous '\n' around error_report()
When I fixed this before, I didn't split it up (commits 312fd5f 6daf194
be62a2eb). Splitting it up is fine, of course. Having the catch-all as
PATCH 05/11 is a bit odd, though. Its qemu-img.c hunk could go into
PATCH 01, because qemu-img is part of the block subsystem. Not worth a
respin as far as I'm concerned.
Reviewed-by: Markus Armbruster <address@hidden>
- Re: [Qemu-trivial] [PATCH 03/11] pl330.c: remove superfluous '\n' around error_setg, (continued)
- [Qemu-trivial] [PATCH 09/11] tpm: Remove superfluous '\n' around error_report(), arei.gonglei, 2015/02/10
- [Qemu-trivial] [PATCH 10/11] arm/digic_boards: Remove superfluous '\n' around error_report(), arei.gonglei, 2015/02/10
- [Qemu-trivial] [PATCH 08/11] xtensa: Remove superfluous '\n' around error_report(), arei.gonglei, 2015/02/10
- [Qemu-trivial] [PATCH 07/11] vfio: Remove superfluous '\n' around error_report(), arei.gonglei, 2015/02/10
- [Qemu-trivial] [PATCH 04/11] numa: remove superfluous '\n' around error_setg, arei.gonglei, 2015/02/10
- [Qemu-trivial] [PATCH 01/11] block: remove superfluous '\n' around error_report/error_setg, arei.gonglei, 2015/02/10
- [Qemu-trivial] [PATCH 02/11] a9gtimer: remove superfluous '\n' around error_setg, arei.gonglei, 2015/02/10
- [Qemu-trivial] [PATCH 11/11] vhost: Remove superfluous '\n' around error_report(), arei.gonglei, 2015/02/10
- [Qemu-trivial] [PATCH 06/11] vhost-scsi: Remove superfluous '\n' around error_report(), arei.gonglei, 2015/02/10
- Re: [Qemu-trivial] [Qemu-devel] [PATCH 00/11] trivial: Remove superfluous '\n' around error_report/error_setg,
Markus Armbruster <=