[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] virtio-input: enable on non-linux hosts

From: Paolo Bonzini
Subject: Re: [Qemu-trivial] [PATCH] virtio-input: enable on non-linux hosts
Date: Mon, 13 Jul 2015 14:17:08 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1

On 13/07/2015 14:01, Gerd Hoffmann wrote:
>> > 
>> > Did a build test on freebsd -- passed.
> Oops, the windows cross builds fails though (due to
> include/standard-headers/linux/input.h including sys/ioctl.h).
> Ok, scratch that one, back to the drawing board ...

The sys/ioctl.h include doesn't seem too useful.  This patch compiles:

diff --git a/hw/input/virtio-input-host.c b/hw/input/virtio-input-host.c
index f7e3d84..3feecfd 100644
--- a/hw/input/virtio-input-host.c
+++ b/hw/input/virtio-input-host.c
@@ -12,6 +12,7 @@
 #include "hw/virtio/virtio-input.h"

 #include "standard-headers/linux/input.h"
+#include <sys/ioctl.h>

 /* ----------------------------------------------------------------- */

diff --git a/include/standard-headers/linux/input.h
index a459dd2..b003c67 100644
--- a/include/standard-headers/linux/input.h
+++ b/include/standard-headers/linux/input.h
@@ -10,7 +10,6 @@

 #include <sys/time.h>
-#include <sys/ioctl.h>
 #include <sys/types.h>
 #include "standard-headers/linux/types.h"

Perhaps we can drop the include in scripts/update-linux-headers.sh?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]