[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] qmp-shell: add documentation

From: Markus Armbruster
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] qmp-shell: add documentation
Date: Thu, 23 Jul 2015 09:36:38 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)

John Snow <address@hidden> writes:

> On 07/02/2015 11:31 AM, Luiz Capitulino wrote:
>> On Wed,  1 Jul 2015 14:25:49 -0400
>> John Snow <address@hidden> wrote:
>>> I should probably document the changes that were made.

John, what do you mean here?

>>> Signed-off-by: John Snow <address@hidden>
>> Looks good to me, CC'ing maintainer.

Luiz, is this a R-by?

> Whoops, didn't realize Markus took this file over, too. Sorry Luiz.

Don't worry about our maintainer reshuffling.

> Markus, would you consider staging this? It's purely a documentation
> update for only a dev tool, so it doesn't really matter /when/ it lands
> either way, just shoring up some changes I made a while back to the
> interpreter here.
> tldr: "ping"

I'm happy to include this in the next pull after it got reviewed.  I'm
ignorant about qmp-shell, because I don't use it myself, so I'd have to
dig through it to verify your documentation is accurate and reasonably

Fishing for more qualified reviewers:

    $ scripts/get_maintainer.pl --git-blame -f scripts/qmp/qmp-shell 
    Markus Armbruster <address@hidden> (supporter:QMP)
    Luiz Capitulino <address@hidden> (authored 
    John Snow <address@hidden> (authored lines:117/390=30%,commits:4/10=40%)
    "Daniel P. Berrange" <address@hidden> (authored lines:27/390=7%)
    Eric Blake <address@hidden> (commits:6/10=60%)
    Stefan Hajnoczi <address@hidden> (commits:2/10=20%)
    Benoit Canet <address@hidden> (commits:1/10=10%)

Luiz, can you review for accuracy and reasonable completeness?

Of course, I'm the reviewer of last resort for anything I maintain,
whether I understand it or not :)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]