[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH v3] opts: produce valid command l

From: Stefan Hajnoczi
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v3] opts: produce valid command line in qemu_opts_print
Date: Tue, 28 Jul 2015 13:30:43 +0100

On Tue, Jul 7, 2015 at 3:42 PM, Kővágó, Zoltán <address@hidden> wrote:
> This will let us print options in a format that the user would actually
> write it on the command line (foo=bar,baz=asd,etc=def), without
> prepending a spurious comma at the beginning of the list, or quoting
> values unnecessarily.  This patch provides the following changes:
> * write and id=, if the option has an id
> * do not print separator before the first element
> * do not quote string arguments
> * properly escape commas (,) for QEMU
> Signed-off-by: Kővágó, Zoltán <address@hidden>
> Reviewed-by: Markus Armbruster <address@hidden>

Feel free to send a "Ping" email reply if your patches haven't been
reviewed after about 1 week.

Reviewed-by: Stefan Hajnoczi <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]