[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH v4 09/11] target-arm: dfilter support for in_a
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-trivial] [PATCH v4 09/11] target-arm: dfilter support for in_asm, op, opt_op |
Date: |
Tue, 4 Aug 2015 14:23:16 +0200 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On 2015-08-03 10:14, Alex Bennée wrote:
> Each individual architecture needs to use the qemu_log_in_addr_range()
> feature for enabling in_asm and marking blocks for op/opt_op output.
>
> Signed-off-by: Alex Bennée <address@hidden>
> ---
> target-arm/translate-a64.c | 6 ++++--
> target-arm/translate.c | 6 ++++--
> 2 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c
> index 689f2be..0b0f4ae 100644
> --- a/target-arm/translate-a64.c
> +++ b/target-arm/translate-a64.c
> @@ -11026,7 +11026,8 @@ void gen_intermediate_code_internal_a64(ARMCPU *cpu,
> gen_io_start();
> }
>
> - if (unlikely(qemu_loglevel_mask(CPU_LOG_TB_OP | CPU_LOG_TB_OP_OPT)))
> {
> + if (unlikely(qemu_loglevel_mask(CPU_LOG_TB_OP | CPU_LOG_TB_OP_OPT) &&
> + qemu_log_in_addr_range(dc->pc))) {
> tcg_gen_debug_insn_start(dc->pc);
> }
>
> @@ -11131,7 +11132,8 @@ done_generating:
> gen_tb_end(tb, num_insns);
>
> #ifdef DEBUG_DISAS
> - if (qemu_loglevel_mask(CPU_LOG_TB_IN_ASM)) {
> + if (qemu_loglevel_mask(CPU_LOG_TB_IN_ASM) &&
> + qemu_log_in_addr_range(pc_start)) {
> qemu_log("----------------\n");
> qemu_log("IN: %s\n", lookup_symbol(pc_start));
> log_target_disas(cs, pc_start, dc->pc - pc_start,
> diff --git a/target-arm/translate.c b/target-arm/translate.c
> index 69ac18c..c914be0 100644
> --- a/target-arm/translate.c
> +++ b/target-arm/translate.c
> @@ -11316,7 +11316,8 @@ static inline void
> gen_intermediate_code_internal(ARMCPU *cpu,
> if (num_insns + 1 == max_insns && (tb->cflags & CF_LAST_IO))
> gen_io_start();
>
> - if (unlikely(qemu_loglevel_mask(CPU_LOG_TB_OP | CPU_LOG_TB_OP_OPT)))
> {
> + if (unlikely(qemu_loglevel_mask(CPU_LOG_TB_OP | CPU_LOG_TB_OP_OPT))
> &&
> + qemu_log_in_addr_range(dc->pc)) {
> tcg_gen_debug_insn_start(dc->pc);
> }
>
> @@ -11489,7 +11490,8 @@ done_generating:
> gen_tb_end(tb, num_insns);
>
> #ifdef DEBUG_DISAS
> - if (qemu_loglevel_mask(CPU_LOG_TB_IN_ASM)) {
> + if (qemu_loglevel_mask(CPU_LOG_TB_IN_ASM) &&
> + qemu_log_in_addr_range(pc_start)) {
> qemu_log("----------------\n");
> qemu_log("IN: %s\n", lookup_symbol(pc_start));
> log_target_disas(cs, pc_start, dc->pc - pc_start,
We probably want to do the same for the other architectures.
Reviewed-by: Aurelien Jarno <address@hidden>
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
address@hidden http://www.aurel32.net
- Re: [Qemu-trivial] [PATCH v4 01/11] tcg: add ability to dump /tmp/perf-<pid>.map files, (continued)
- Re: [Qemu-trivial] [PATCH v4 01/11] tcg: add ability to dump /tmp/perf-<pid>.map files, Alex Bennée, 2015/08/04
- Re: [Qemu-trivial] [PATCH v4 01/11] tcg: add ability to dump /tmp/perf-<pid>.map files, Paolo Bonzini, 2015/08/04
- Re: [Qemu-trivial] [PATCH v4 01/11] tcg: add ability to dump /tmp/perf-<pid>.map files, Aurelien Jarno, 2015/08/04
- Re: [Qemu-trivial] [PATCH v4 01/11] tcg: add ability to dump /tmp/perf-<pid>.map files, Alex Bennée, 2015/08/04
- Re: [Qemu-trivial] [Qemu-devel] [PATCH v4 01/11] tcg: add ability to dump /tmp/perf-<pid>.map files, Aurelien Jarno, 2015/08/04
Re: [Qemu-trivial] [PATCH v4 01/11] tcg: add ability to dump /tmp/perf-<pid>.map files, Aurelien Jarno, 2015/08/04
[Qemu-trivial] [PATCH v4 05/11] qemu-log: Improve the "exec" TB execution logging, Alex Bennée, 2015/08/03
[Qemu-trivial] [PATCH v4 09/11] target-arm: dfilter support for in_asm, op, opt_op, Alex Bennée, 2015/08/03
[Qemu-trivial] [PATCH v4 07/11] qemu-log: new option -dfilter to limit output, Alex Bennée, 2015/08/03
[Qemu-trivial] [PATCH v4 06/11] qemu-log: support simple pid substitution in logfile, Alex Bennée, 2015/08/03
[Qemu-trivial] [PATCH v4 08/11] qemu-log: dfilter-ise exec, out_asm, and op_opt, Alex Bennée, 2015/08/03