[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH 1/3] Target-microblaze: Remove unnecessary var

From: Michael Tokarev
Subject: Re: [Qemu-trivial] [PATCH 1/3] Target-microblaze: Remove unnecessary variable
Date: Mon, 05 Oct 2015 10:18:47 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0

05.10.2015 08:18, Markus Armbruster wrote:
> Michael Tokarev <address@hidden> writes:
>> 25.09.2015 11:37, Shraddha Barke wrote:
>>> Compress lines and remove the variable .
>> Applied to -trivial, removing this piece of commit message:
>> ---
>>> Change made using Coccinelle script
>> ---
> Why?  I like having the semantic patch in the commit message when
> there's any chance we'll want do the same mechanical change again later.
> You could save space and include it by reference, though: "Same
> Coccinelle semantic patch as is commit 74c373e".

git commit messages aren't good documentation for various scripts
like this, this info will be lost in the noize.  If it might be
better to keep such scripts in a separate file where it is easier
to find, or in a wiki page on the site. The key point is where to
find the info, git log is difficult for that, especially when you
don't know what to search for or that such a script exists in
there in the first place.

On the other hand, when git log is cluttered by such a long messages
for such small changes, it becomes more difficult to find info which
you really look in git log -- namely, which changes were made that
might have introduced this regression, things like that.

So to me, the shorter and cleaner the commit message is, the better.

BTW, I've no idea why this email has been Cc'd to address@hidden :)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]