[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] tci: Fix build with no '-DNDEBUG'

From: Stefan Weil
Subject: Re: [Qemu-trivial] [PATCH] tci: Fix build with no '-DNDEBUG'
Date: Mon, 4 Apr 2016 19:53:54 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.7.0

Am 04.04.2016 um 15:22 schrieb Sergey Fedorov:
> On 04/04/16 14:56, Stefan Weil wrote:
>> There is indeed a regression in the current code. Commit
>> d38ea87ac54af64ef611de434d07c12dc0399216 added an include statement
>> which includes assert.h before NDEBUG is defined. This is wrong and
>> needs a fix. Could you please try tci.c starting like this?
>> /* Defining NDEBUG disables assertions (which makes the code faster). */
>> #if !defined(CONFIG_DEBUG_TCG) && !defined(NDEBUG)
>> # define NDEBUG
>> #endif
>> #include "qemu/osdep.h"
> Doing so really helps. So what are the plans of how to fix the problem?
> Thanks,
> Sergey

The correct fix needs a little bit more code because my first try (see
above) did not get the definition of macro CONFIG_DEBUG_TCG.

My patch was now sent to the list.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]