[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] hw/net/opencores_eth: Allocating Large sized

From: Max Filippov
Subject: Re: [Qemu-trivial] [PATCH] hw/net/opencores_eth: Allocating Large sized arrays to heap
Date: Tue, 26 Apr 2016 07:12:18 +0300

Hi Zhou,

On Tue, Apr 26, 2016 at 6:35 AM, Zhou Jie <address@hidden> wrote:
> open_eth_start_xmit has a huge stack usage of 65536 bytes approx.
> Moving large arrays to heap to reduce stack usage.

It's an exception, not the rule when full 65536 byte long buffer might be
needed. Can we do a little better change and not allocate and free this
buffer every time unconditionally, but instead make buf smaller (1536
bytes, maximal frame length when HUGEN bit is not set in MODER)
and only do allocation when that's not enough?

-- Max

reply via email to

[Prev in Thread] Current Thread [Next in Thread]