[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] configure: Check if struct fsxattr is availab

From: Peter Maydell
Subject: Re: [Qemu-trivial] [PATCH] configure: Check if struct fsxattr is available from linux header
Date: Fri, 29 Apr 2016 15:00:10 +0100

On 29 April 2016 at 14:56, Stefan Weil <address@hidden> wrote:
> Am 29.04.2016 um 15:54 schrieb Peter Maydell:
>> This means we'll build with a HAVE_FSXATTR define set, but
>> nothing in the tree tries to use that as far as I can tell:
>> "git grep HAVE_FSXATTR" returns no matches. What am I missing?

> It's used by the system headers:
> /usr/include/xfs/xfs_fs.h:#ifndef HAVE_FSXATTR

...so this is a bug in the system headers that we're working
around? It would probably be useful to say so in a comment
in configure, otherwise it's liable to get ripped out in
future when somebody notices it's not used any more.
(For instance HAVE_IFADDRS_H isn't used and looks like dead
code in configure.)

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]