[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PATCH] target-m68k: fix get_mac_extf helper
From: |
Paolo Bonzini |
Subject: |
[Qemu-trivial] [PATCH] target-m68k: fix get_mac_extf helper |
Date: |
Fri, 15 Jul 2016 17:29:22 +0200 |
val is assigned twice; the second one should be combined with "|".
Reported by Coverity.
Signed-off-by: Paolo Bonzini <address@hidden>
---
target-m68k/helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-m68k/helper.c b/target-m68k/helper.c
index f52d0e3..89bbe6d 100644
--- a/target-m68k/helper.c
+++ b/target-m68k/helper.c
@@ -812,7 +812,7 @@ uint32_t HELPER(get_mac_extf)(CPUM68KState *env, uint32_t
acc)
{
uint32_t val;
val = env->macc[acc] & 0x00ff;
- val = (env->macc[acc] >> 32) & 0xff00;
+ val |= (env->macc[acc] >> 32) & 0xff00;
val |= (env->macc[acc + 1] << 16) & 0x00ff0000;
val |= (env->macc[acc + 1] >> 16) & 0xff000000;
return val;
--
2.7.4
- [Qemu-trivial] [PATCH] target-m68k: fix get_mac_extf helper,
Paolo Bonzini <=