[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH 07/29] ds1338: use QEMU_IS_ALIGNED macro
From: |
Alastair D'Silva |
Subject: |
Re: [Qemu-trivial] [PATCH 07/29] ds1338: use QEMU_IS_ALIGNED macro |
Date: |
Tue, 18 Jul 2017 20:23:42 +1000 |
I'm not sure this makes sense - we're dealing with time here.
--
Alastair D'Silva mob: 0423 762 819
skype: alastair_dsilva msn: address@hidden
blog: http://alastair.d-silva.org Twitter: @EvilDeece
> -----Original Message-----
> From: Philippe Mathieu-Daudé [mailto:address@hidden
> On Behalf Of Philippe Mathieu-Daudé
> Sent: Tuesday, 18 July 2017 4:10 PM
> To: address@hidden; Peter Maydell <address@hidden>;
> Alastair D'Silva <address@hidden>; Corey Minyard
> <address@hidden>
> Cc: Philippe Mathieu-Daudé <address@hidden>; address@hidden;
> Eric Blake <address@hidden>
> Subject: [PATCH 07/29] ds1338: use QEMU_IS_ALIGNED macro
>
> Applied using the Coccinelle semantic patch
> scripts/coccinelle/use_osdep.cocci
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/timer/ds1338.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/timer/ds1338.c b/hw/timer/ds1338.c index
> 3849b74a68..a77fe14514 100644
> --- a/hw/timer/ds1338.c
> +++ b/hw/timer/ds1338.c
> @@ -65,7 +65,7 @@ static void capture_current_time(DS1338State *s)
> s->nvram[1] = to_bcd(now.tm_min);
> if (s->nvram[2] & HOURS_12) {
> int tmp = now.tm_hour;
> - if (tmp % 12 == 0) {
> + if (QEMU_IS_ALIGNED(tmp, 12)) {
> tmp += 12;
> }
> if (tmp <= 12) {
> @@ -154,7 +154,7 @@ static int ds1338_send(I2CSlave *i2c, uint8_t data)
> if (data & HOURS_PM) {
> tmp += 12;
> }
> - if (tmp % 12 == 0) {
> + if (QEMU_IS_ALIGNED(tmp, 12)) {
> tmp -= 12;
> }
> now.tm_hour = tmp;
> --
> 2.13.2
>
>
> ---
> This email has been checked for viruses by AVG.
> http://www.avg.com
- [Qemu-trivial] [PATCH 03/29] qemu-img: use QEMU_IS_ALIGNED macro, (continued)
- [Qemu-trivial] [PATCH 03/29] qemu-img: use QEMU_IS_ALIGNED macro, Philippe Mathieu-Daudé, 2017/07/18
- [Qemu-trivial] [PATCH 04/29] scsi-disk: use QEMU_IS_ALIGNED macro, Philippe Mathieu-Daudé, 2017/07/18
- [Qemu-trivial] [PATCH 05/29] block: use QEMU_IS_ALIGNED macro, Philippe Mathieu-Daudé, 2017/07/18
- [Qemu-trivial] [PATCH 06/29] migration/block: use QEMU_IS_ALIGNED macro, Philippe Mathieu-Daudé, 2017/07/18
- [Qemu-trivial] [PATCH 07/29] ds1338: use QEMU_IS_ALIGNED macro, Philippe Mathieu-Daudé, 2017/07/18
- Re: [Qemu-trivial] [PATCH 07/29] ds1338: use QEMU_IS_ALIGNED macro,
Alastair D'Silva <=
- [Qemu-trivial] [PATCH 08/29] ui: use QEMU_IS_ALIGNED macro, Philippe Mathieu-Daudé, 2017/07/18
- [Qemu-trivial] [PATCH 09/29] net: use QEMU_IS_ALIGNED macro, Philippe Mathieu-Daudé, 2017/07/18
- [Qemu-trivial] [PATCH 10/29] net/rocker: use QEMU_IS_ALIGNED macro, Philippe Mathieu-Daudé, 2017/07/18
- [Qemu-trivial] [PATCH 11/29] s390x/sclp: use QEMU_IS_ALIGNED macro, Philippe Mathieu-Daudé, 2017/07/18