Re: [Qemu-trivial] [PATCH v3 34/42] hw/acpi/ich9: extract ACPI_PM_PROP_TCO_ENABLED from i386/pc

[Igor Mammedov]

On Tue, 17 Oct 2017 13:44:18 -0300
Philippe Mathieu-Daudé <address@hidden> wrote:

> enable_tco is specific to i386/pc.
> 
> Suggested-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>

> ---
>  include/hw/acpi/ich9.h | 2 ++
>  include/hw/i386/pc.h   | 2 --
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/hw/acpi/ich9.h b/include/hw/acpi/ich9.h
> index a352c94fde..59aeb06393 100644
> --- a/include/hw/acpi/ich9.h
> +++ b/include/hw/acpi/ich9.h
> @@ -63,6 +63,8 @@ typedef struct ICH9LPCPMRegs {
>      TCOIORegs tco_regs;
>  } ICH9LPCPMRegs;
>  
> +#define ACPI_PM_PROP_TCO_ENABLED "enable_tco"
> +
>  void ich9_pm_init(PCIDevice *lpc_pci, ICH9LPCPMRegs *pm,
>                    bool smm_enabled,
>                    qemu_irq sci_irq);
> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> index 6335e2bf47..b1b4c918af 100644
> --- a/include/hw/i386/pc.h
> +++ b/include/hw/i386/pc.h
> @@ -151,8 +151,6 @@ struct PCMachineClass {
>  #define PC_MACHINE_CLASS(klass) \
>      OBJECT_CLASS_CHECK(PCMachineClass, (klass), TYPE_PC_MACHINE)
>  
> -#define ACPI_PM_PROP_TCO_ENABLED "enable_tco"
> -
>  /* parallel.c */
>  
>  void parallel_hds_isa_init(ISABus *bus, int n);