[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] opts: fix NULL pointer derefernce in get_opt_
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-trivial] [PATCH] opts: fix NULL pointer derefernce in get_opt_value |
Date: |
Mon, 16 Jul 2018 19:47:52 +0100 |
User-agent: |
Mutt/1.10.0 (2018-05-17) |
On Mon, Jul 16, 2018 at 06:41:46PM +0100, Mike Krinkin wrote:
> The value argument can be NULL, for example, in hw/i386/multiboot.c
> in the load_multiboot function get_opt_value is explicitly called
> with NULL as the second argument.
>
> The problem was introduced in commit 950c4e6c94b1 ("opts: don't
> silently truncate long option values"). This change fixes the
> problem by adding a check whether the value is NULL or not.
>
> Signed-off-by: Mike Krinkin <address@hidden>
> ---
> util/qemu-option.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
This problem is fixed in this:
https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg01490.html
but it is still waiting for i386 maintainers to respond....
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|