[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] vl: Use error_fatal to simplify
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] vl: Use error_fatal to simplify obvious fatal errors (again) |
Date: |
Fri, 14 Dec 2018 11:43:56 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 |
On 12/13/18 6:58 PM, Markus Armbruster wrote:
> Patch created mechanically by rerunning:
>
> $ spatch --in-place --sp-file scripts/coccinelle/use-error_fatal.cocci \
> --macro-file scripts/cocci-macro-file.h vl.c
>
> Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> vl.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index a5ae5f23d2..702a828ca2 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3138,11 +3138,8 @@ int main(int argc, char **argv, char **envp)
> Visitor *v;
> BlockdevOptions_queue *bdo;
>
> - v = qobject_input_visitor_new_str(optarg, "driver",
> &err);
> - if (!v) {
> - error_report_err(err);
> - exit(1);
> - }
> + v = qobject_input_visitor_new_str(optarg, "driver",
> + &error_fatal);
>
> bdo = g_new(BlockdevOptions_queue, 1);
> visit_type_BlockdevOptions(v, NULL, &bdo->bdo,
>