[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-trivial] [PULL 6/7] hw/cpu/cluster: Mark the cpu-cluster device wi

From: Laurent Vivier
Subject: [Qemu-trivial] [PULL 6/7] hw/cpu/cluster: Mark the cpu-cluster device with user_creatable = false
Date: Wed, 6 Feb 2019 16:28:06 +0100

From: Thomas Huth <address@hidden>

The device can not be instantiated by the user and QEMU currently
aborts when you try to use it:

$ x86_64-softmmu/qemu-system-x86_64 -device cpu-cluster
qemu-system-x86_64: hw/cpu/cluster.c:73: cpu_cluster_realize:
 Assertion `cbdata.cpu_count > 0' failed.
Aborted (core dumped)

Since this is an internal device only, mark it with user_creatable = false.

Signed-off-by: Thomas Huth <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Luc Michel <address@hidden>
Reviewed-by: Alistair Francis <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
 hw/cpu/cluster.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/hw/cpu/cluster.c b/hw/cpu/cluster.c
index 25f90702b1..6f5f037b3c 100644
--- a/hw/cpu/cluster.c
+++ b/hw/cpu/cluster.c
@@ -79,6 +79,9 @@ static void cpu_cluster_class_init(ObjectClass *klass, void 
     dc->props = cpu_cluster_properties;
     dc->realize = cpu_cluster_realize;
+    /* This is not directly for users, CPU children must be attached by code */
+    dc->user_creatable = false;
 static const TypeInfo cpu_cluster_type_info = {

reply via email to

[Prev in Thread] Current Thread [Next in Thread]