[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] hw/dma/i8257: Use qemu_log_mask(UNIMP) instea
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-trivial] [PATCH] hw/dma/i8257: Use qemu_log_mask(UNIMP) instead of fprintf |
Date: |
Thu, 14 Feb 2019 11:02:03 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 12/02/2019 15:53, Philippe Mathieu-Daudé wrote:
> Avoid to clutter stdout until explicitly requested (with -d unimp):
>
> $ qemu-system-mips64el -M fulong2e -bios pmon_2e.bin
> dma: command df not supported
> dma: command df not supported
> dma: command df not supported
> dma: command df not supported
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/dma/i8257.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/hw/dma/i8257.c b/hw/dma/i8257.c
> index 52675e97c9..3e1f13a4aa 100644
> --- a/hw/dma/i8257.c
> +++ b/hw/dma/i8257.c
> @@ -26,6 +26,7 @@
> #include "hw/isa/isa.h"
> #include "hw/dma/i8257.h"
> #include "qemu/main-loop.h"
> +#include "qemu/log.h"
> #include "trace.h"
>
> #define I8257(obj) \
> @@ -185,7 +186,8 @@ static void i8257_write_cont(void *opaque, hwaddr nport,
> uint64_t data,
> switch (iport) {
> case 0x00: /* command */
> if ((data != 0) && (data & CMD_NOT_SUPPORTED)) {
> - dolog("command %"PRIx64" not supported\n", data);
> + qemu_log_mask(LOG_UNIMP, "%s: cmd 0x%02"PRIx64" not supported\n",
> + __func__, data);
> return;
> }
> d->command = data;
>
Applied to my trivial-patches branch.
Thanks,
Laurent