[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] gdbstub: Send a reply to the vKi

From: Sandra Loosemore
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] gdbstub: Send a reply to the vKill packet.
Date: Thu, 14 Feb 2019 11:27:28 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1

On 2/14/19 10:48 AM, Peter Maydell wrote:
On Tue, 12 Feb 2019 at 21:52, Sandra Loosemore <address@hidden> wrote:

Per the GDB remote protocol documentation


the debug stub is expected to send a reply to the 'vKill' packet.  At
least some versions of GDB crash if the gdb stub simply exits without
sending a reply.  This patch fixes QEMU's gdb stub to conform to the
expected behavior.

Note that QEMU's existing handling of the legacy 'k' packet is
correct: in that case GDB does not expect a reply, and QEMU does not
send one.

Signed-off-by: Sandra Loosemore <address@hidden>

Thanks, applied to target-arm.next.

As an aside, do you know if there is any kind of test suite for
the remote protocol that implementors of a debug stub can use to
check that they're conforming to it?

Well, I discovered this problem by running the GDB testsuite (using QEMU for nios2-elf target with the other target-specific patches I recently posted). I'm not sure if it's designed to exhaustively test the entire remote protocol, but it does a pretty good job of covering user-visible GDB features that depend on the remote target doing something reasonable, even if it's just saying "Huh? I don't know how to do that." :-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]