[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PULL 09/14] hw/ipmi: Rewrite a fall through comment
From: |
Corey Minyard |
Subject: |
Re: [Qemu-trivial] [PULL 09/14] hw/ipmi: Rewrite a fall through comment |
Date: |
Wed, 21 Aug 2019 06:48:07 -0500 |
User-agent: |
Mutt/1.9.4 (2018-02-28) |
On Wed, Aug 21, 2019 at 01:19:42PM +0200, Laurent Vivier wrote:
> From: Philippe Mathieu-Daudé <address@hidden>
>
> GCC9 is confused by this comment when building with CFLAG
> -Wimplicit-fallthrough=2:
>
> hw/ipmi/ipmi_bmc_extern.c: In function ‘addchar’:
> hw/ipmi/ipmi_bmc_extern.c:178:12: error: this statement may fall through
> [-Werror=implicit-fallthrough=]
> 178 | ch |= 0x10;
> | ~~~^~~~~~~
> hw/ipmi/ipmi_bmc_extern.c:181:5: note: here
> 181 | default:
> | ^~~~~~~
> cc1: all warnings being treated as errors
> make: *** [rules.mak:69: hw/ipmi/ipmi_bmc_extern.o] Error 1
>
> Rewrite the comment using 'fall through' which is recognized by
> GCC and static analyzers.
Looks good, thanks. I've pulled it into my tree, but if you want
to queue it someplace else:
Reviewed-by: Corey Minyard <address@hidden>
>
> Reported-by: Stefan Weil <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> Acked-by: Corey Minyard <address@hidden>
> Message-Id: <address@hidden>
> Signed-off-by: Laurent Vivier <address@hidden>
> ---
> hw/ipmi/ipmi_bmc_extern.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/hw/ipmi/ipmi_bmc_extern.c b/hw/ipmi/ipmi_bmc_extern.c
> index 573428eca1b2..87da9ff99cf5 100644
> --- a/hw/ipmi/ipmi_bmc_extern.c
> +++ b/hw/ipmi/ipmi_bmc_extern.c
> @@ -177,8 +177,7 @@ static void addchar(IPMIBmcExtern *ibe, unsigned char ch)
> ibe->outbuf[ibe->outlen] = VM_ESCAPE_CHAR;
> ibe->outlen++;
> ch |= 0x10;
> - /* No break */
> -
> + /* fall through */
> default:
> ibe->outbuf[ibe->outlen] = ch;
> ibe->outlen++;
> --
> 2.21.0
>
- [Qemu-trivial] [PULL 01/14] test: Use g_strndup instead of plain strndup, (continued)
- [Qemu-trivial] [PULL 01/14] test: Use g_strndup instead of plain strndup, Laurent Vivier, 2019/08/21
- [Qemu-trivial] [PULL 12/14] spapr_events: Rewrite a fall through comment, Laurent Vivier, 2019/08/21
- [Qemu-trivial] [PULL 13/14] hw/display/sm501: Remove unused include, Laurent Vivier, 2019/08/21
- [Qemu-trivial] [PULL 03/14] configure: remove obsoleted $sparc_cpu variable, Laurent Vivier, 2019/08/21
- [Qemu-trivial] [PULL 11/14] vl: Rewrite a fall through comment, Laurent Vivier, 2019/08/21
- [Qemu-trivial] [PULL 07/14] json: Move switch 'fall through' comment to correct place, Laurent Vivier, 2019/08/21
- [Qemu-trivial] [PULL 08/14] hw/dma/omap_dma: Move switch 'fall through' comment to correct place, Laurent Vivier, 2019/08/21
- [Qemu-trivial] [PULL 02/14] misc: fix naming scheme of compatiblity arrays, Laurent Vivier, 2019/08/21
- [Qemu-trivial] [PULL 05/14] .gitignore: ignore some vhost-user* related files, Laurent Vivier, 2019/08/21
- [Qemu-trivial] [PULL 09/14] hw/ipmi: Rewrite a fall through comment, Laurent Vivier, 2019/08/21
- Re: [Qemu-trivial] [PULL 09/14] hw/ipmi: Rewrite a fall through comment,
Corey Minyard <=
- [Qemu-trivial] [PULL 04/14] configure: fix sdl detection using sdl2-config, Laurent Vivier, 2019/08/21
- Re: [Qemu-trivial] [PULL 00/14] Trivial branch patches, Peter Maydell, 2019/08/22