[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [Qemu-block] [PATCH] qemu-doc: Do not ha

From: Thomas Huth
Subject: Re: [Qemu-trivial] [Qemu-devel] [Qemu-block] [PATCH] qemu-doc: Do not hard-code the name of the QEMU binary
Date: Thu, 29 Aug 2019 07:41:17 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0

On 28/08/2019 21.18, John Snow wrote:
> On 8/28/19 5:34 AM, Thomas Huth wrote:
>> In our documentation, we use a mix of "$QEMU", "qemu-system-i386" and
>> "qemu-system-x86_64" when we give examples to the users how to run
>> QEMU. Some more consistency would be good here. Also some distributions
>> use different names for the QEMU binary (e.g. "qemu-kvm" in RHEL), so
>> providing more flexibility here would also be good. Thus let's define
>> some variables for the names of the QEMU command and use those in the
>> documentation instead: @value{qemu_system} for generic examples, and
>> @value{qemu_system_x86} for examples that only work with the x86
>> binaries.
>> Signed-off-by: Thomas Huth <address@hidden>
> Makes sense to me, but do we want a definitions.texi or similar that can
> be used globally (and is easy to find and edit by e.g. distro
> packagers), or is it better to re-define them per-each file as you've done?

Hmm, as long as it's just one or two variables, it seems a little bit
excessive to me, but if we'd have more config knobs, that would
certainly be the right way to go ... but currently we do not have any
more variables, do we?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]