[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] hw/*/Makefile.objs: Move many .o files to com
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-trivial] [PATCH] hw/*/Makefile.objs: Move many .o files to common-objs |
|
Date: |
Mon, 16 Sep 2019 16:28:52 +0100 |
|
User-agent: |
Mutt/1.12.1 (2019-06-15) |
On Thu, Sep 12, 2019 at 03:10:11PM +0200, Thomas Huth wrote:
> We have many files that apparently do not depend on the target CPU
> configuration, i.e. which can be put into common-obj-y instead of
> obj-y. This way, the code can be shared for example between
> qemu-system-arm and qemu-system-aarch64, or the various big and
> little endian variants like qemu-system-sh4 and qemu-system-sh4eb,
> so that we do not have to compile the code multiple times anymore.
>
> Signed-off-by: Thomas Huth <address@hidden>
> ---
> hw/adc/Makefile.objs | 2 +-
> hw/block/Makefile.objs | 2 +-
> hw/char/Makefile.objs | 16 ++++++++--------
> hw/core/Makefile.objs | 2 +-
> hw/display/Makefile.objs | 2 +-
> hw/dma/Makefile.objs | 6 +++---
> hw/gpio/Makefile.objs | 8 ++++----
> hw/i2c/Makefile.objs | 4 ++--
> hw/i2c/ppc4xx_i2c.c | 1 -
> hw/input/Makefile.objs | 6 +++---
> hw/net/Makefile.objs | 6 +++---
> hw/nvram/Makefile.objs | 2 +-
> hw/pcmcia/Makefile.objs | 2 +-
> hw/sd/Makefile.objs | 8 ++++----
> hw/ssi/Makefile.objs | 4 ++--
> hw/timer/Makefile.objs | 22 +++++++++++-----------
> hw/usb/Makefile.objs | 4 ++--
> 17 files changed, 48 insertions(+), 49 deletions(-)
Nice. Again, I think the poisoned symbols would break compilation and
CI would tell us if any changes made in this patch were incorrect.
Therefore, looks good:
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature