Re: [PATCH] qemu_set_log_filename: filename argument may be NULL

[Stefan Hajnoczi]

On Wed, Jan 22, 2020 at 10:08:12PM +0100, address@hidden wrote:

Existing callers like vl.c:main() do:

   if (log_file) {
        qemu_set_log_filename(log_file, &error_fatal);
   }

Please fix up existing callers.  They won't need to check for NULL
anymore before calling qemu_set_log_filename().

> +    /* else, let logfilename be NULL indicating we want to use stderr */

Please update the doc comment instead.  That way callers know that
passing NULL is allowed without reading the implementation.

signature.asc
Description: PGP signature