[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] qemu_set_log_filename: filename argument may be NULL
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH] qemu_set_log_filename: filename argument may be NULL |
Date: |
Fri, 24 Jan 2020 10:24:47 +0000 |
On Thu, Jan 23, 2020 at 08:36:26PM +0100, address@hidden wrote:
> From: Salvador Fandino <address@hidden>
>
> NULL is a valid log filename used to indicate we want to use stderr
> but qemu_set_log_filename (which is called by bsd-user/main.c) was not
> handling it correctly.
>
> That also made redundant a couple of NULL checks in calling code which
> have been removed.
>
> Signed-off-by: Salvador Fandino <address@hidden>
> ---
> trace/control.c | 4 +---
> util/log.c | 28 ++++++++++++++++------------
> vl.c | 5 +----
> 3 files changed, 18 insertions(+), 19 deletions(-)
Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing
Stefan
signature.asc
Description: PGP signature