|
From: | Salvador Fandiño |
Subject: | Re: [PATCH] bsd-user: improve support for sparc syscall flags |
Date: | Sat, 25 Jan 2020 20:09:34 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
Le 25/01/2020 à 12:55, address@hidden a écrit :Patchew URL: https://patchew.org/QEMU/address@hidden/ Hi, This series seems to have some coding style problems. See output below for more information:Salvador, you can use scripts/checkpatch.pl in the QEMU directory to check your patch for style before sending them. And don't send them as a reply but as a new thread, using versioning in the subject ("[PATCH v4]").
ok, I will do that in the future.
In any case, the style problems found by patchew for the last
version of the patch I have submitted are for a fragment of a file
copied verbatim from the NetBSD source code (in the same way the
equivalent fragment was copied from OpenBSD when support for that
OS was added). It is mostly the copyright header and a few
defines. IMO, style shouldn't be corrected there.
[Prev in Thread] | Current Thread | [Next in Thread] |