qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] target/arm/monitor: query-cpu-model-expansion crashed qemu w


From: no-reply
Subject: Re: [PATCH] target/arm/monitor: query-cpu-model-expansion crashed qemu when using machine type none
Date: Fri, 31 Jan 2020 13:33:34 -0800 (PST)

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH] target/arm/monitor: query-cpu-model-expansion crashed qemu 
when using machine type none
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
   aeab8e5..28db64f  master     -> master
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
54bd33b target/arm/monitor: query-cpu-model-expansion crashed qemu when using 
machine type none

=== OUTPUT BEGIN ===
ERROR: code indent should never use tabs
#43: FILE: target/arm/monitor.c:149:
+^I^I^I    !strncmp(model->name, cpu_type, len)) {$

ERROR: code indent should never use tabs
#44: FILE: target/arm/monitor.c:150:
+^I^I    /* KVM is enabled and we're using this type, so it works. */$

ERROR: code indent should never use tabs
#45: FILE: target/arm/monitor.c:151:
+^I^I    supported = true;$

total: 3 errors, 0 warnings, 25 lines checked

Commit 54bd33b5bf01 (target/arm/monitor: query-cpu-model-expansion crashed qemu 
when using machine type none) has style problems, please review.  If any of 
these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]