qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 13/13] monitor/hmp-cmds: Remove redundant statement in hmp_ro


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 13/13] monitor/hmp-cmds: Remove redundant statement in hmp_rocker_of_dpa_groups()
Date: Tue, 25 Feb 2020 10:44:31 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

On 2/25/20 3:09 AM, address@hidden wrote:
From: Chen Qun <address@hidden>

Clang static code analyzer show warning:
monitor/hmp-cmds.c:2867:17: warning: Value stored to 'set' is never read
                 set = true;
                 ^     ~~~~

Reported-by: Euler Robot <address@hidden>
Signed-off-by: Chen Qun <address@hidden>
---
Cc: "Dr. David Alan Gilbert" <address@hidden>
---
  monitor/hmp-cmds.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
index 53bc3f76c4..84f94647cd 100644
--- a/monitor/hmp-cmds.c
+++ b/monitor/hmp-cmds.c
@@ -2864,7 +2864,6 @@ void hmp_rocker_of_dpa_groups(Monitor *mon, const QDict 
*qdict)
if (group->has_set_eth_dst) {
              if (!set) {
-                set = true;
                  monitor_printf(mon, " set");
              }
              monitor_printf(mon, " dst %s", group->set_eth_dst);


Can you move the 'set' declaration to the for() statement and also remove the last "set = false;"?




reply via email to

[Prev in Thread] Current Thread [Next in Thread]