[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] util/oslib-win32: Improve error report by calling error_
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 2/2] util/oslib-win32: Improve error report by calling error_setg_win32() |
Date: |
Thu, 27 Feb 2020 15:42:52 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Philippe Mathieu-Daudé <address@hidden> writes:
> Use error_setg_win32() which adds a hint similar to strerror(errno)).
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> util/oslib-win32.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/util/oslib-win32.c b/util/oslib-win32.c
> index e9b14ab178..d2fca1808d 100644
> --- a/util/oslib-win32.c
> +++ b/util/oslib-win32.c
> @@ -46,7 +46,8 @@
> void *qemu_oom_check(void *ptr)
> {
> if (ptr == NULL) {
> - fprintf(stderr, "Failed to allocate memory: %lu\n", GetLastError());
> + g_autofree gchar *emsg = g_win32_error_message(GetLastError());
Since we're on a path to abort(), I wouldn't bother with g_autofree.
> + fprintf(stderr, "Failed to allocate memory: %s\n", emsg);
Any particular reason not to use error_report()?
> abort();
> }
> return ptr;