qemu-trivial
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Inconsistency - potential bug

From: Mansour Ahmadi
Subject: Inconsistency - potential bug
Date: Thu, 5 Mar 2020 16:22:46 -0500
Hi

It seems there is an inconsistency here:

https://github.com/qemu/qemu/blob/55afdac3b29e672aad51e953412364127e54268b/disas/ppc.c#L996
if (((insn & (1 << 21)) == 0) != ((insn & (1 << 15)) == 0))
*invalid = 1;
https://github.com/qemu/qemu/blob/55afdac3b29e672aad51e953412364127e54268b/disas/ppc.c#L1041
if (((insn & (1 << 21)) == 0) == ((insn & (1 << 15)) == 0))
*invalid = 1;

Does "==" need to be changed to "!="?

Mansour

reply via email to
[Prev in Thread] Current Thread [Next in Thread]