[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 03/12] block/file-posix: Remove redundant statement in raw
From: |
Laurent Vivier |
Subject: |
Re: [PATCH v3 03/12] block/file-posix: Remove redundant statement in raw_handle_perm_lock() |
Date: |
Mon, 9 Mar 2020 13:18:02 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
Le 02/03/2020 à 14:07, Chen Qun a écrit :
> Clang static code analyzer show warning:
> block/file-posix.c:891:9: warning: Value stored to 'op' is never read
> op = RAW_PL_ABORT;
> ^ ~~~~~~~~~~~~
>
> Reported-by: Euler Robot <address@hidden>
> Signed-off-by: Chen Qun <address@hidden>
> Reviewed-by: Kevin Wolf <address@hidden>
> ---
> Cc: Kevin Wolf <address@hidden>
> Cc: Max Reitz <address@hidden>
> ---
> block/file-posix.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/block/file-posix.c b/block/file-posix.c
> index 6345477112..0f77447a25 100644
> --- a/block/file-posix.c
> +++ b/block/file-posix.c
> @@ -888,7 +888,6 @@ static int raw_handle_perm_lock(BlockDriverState *bs,
> "Is another process using the image [%s]?\n",
> bs->filename);
> }
> - op = RAW_PL_ABORT;
> /* fall through to unlock bytes. */
> case RAW_PL_ABORT:
> raw_apply_lock_bytes(s, s->fd, s->perm, ~s->shared_perm,
>
Applied to my trivial-patches branch.
Thanks,
Laurent
- Re: [PATCH v3 02/12] block/iscsi:Remove redundant statement in iscsi_open(), (continued)
[PATCH v3 06/12] display/pxa2xx_lcd: Remove redundant statement in pxa2xx_palette_parse(), Chen Qun, 2020/03/02
[PATCH v3 04/12] scsi/esp-pci: Remove redundant statement in esp_pci_io_write(), Chen Qun, 2020/03/02
[PATCH v3 03/12] block/file-posix: Remove redundant statement in raw_handle_perm_lock(), Chen Qun, 2020/03/02
- Re: [PATCH v3 03/12] block/file-posix: Remove redundant statement in raw_handle_perm_lock(),
Laurent Vivier <=
[PATCH v3 09/12] dma/xlnx-zdma: Remove redundant statement in zdma_write_dst(), Chen Qun, 2020/03/02
[PATCH v3 08/12] display/blizzard: Remove redundant statement in blizzard_draw_line16_32(), Chen Qun, 2020/03/02
[PATCH v3 01/12] block/stream: Remove redundant statement in stream_run(), Chen Qun, 2020/03/02
[PATCH v3 00/12] redundant code: Fix warnings reported by Clang static code analyzer, Chen Qun, 2020/03/02
[PATCH v3 12/12] monitor/hmp-cmds: Remove redundant statement in hmp_rocker_of_dpa_groups(), Chen Qun, 2020/03/02