[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 4/9] hw/input/adb-kbd: Remove dead assignment
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v3 4/9] hw/input/adb-kbd: Remove dead assignment |
Date: |
Wed, 22 Apr 2020 15:31:47 +0200 |
Since commit 5a1f49718 the 'olen' variable is not really
used. Remove it to fix a warning reported by Clang static
code analyzer:
CC hw/input/adb-kbd.o
hw/input/adb-kbd.c:200:5: warning: Value stored to 'olen' is never read
olen = 0;
^ ~
Fixes: 5a1f49718 (adb: add support for QKeyCode)
Reported-by: Clang Static Analyzer
Suggested-by: BALATON Zoltan <address@hidden>
Acked-by: David Gibson <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
hw/input/adb-kbd.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/hw/input/adb-kbd.c b/hw/input/adb-kbd.c
index 0ba8207589..a6d5c9b7c9 100644
--- a/hw/input/adb-kbd.c
+++ b/hw/input/adb-kbd.c
@@ -195,9 +195,7 @@ static int adb_kbd_poll(ADBDevice *d, uint8_t *obuf)
{
KBDState *s = ADB_KEYBOARD(d);
int keycode;
- int olen;
- olen = 0;
if (s->count == 0) {
return 0;
}
@@ -216,7 +214,6 @@ static int adb_kbd_poll(ADBDevice *d, uint8_t *obuf)
if (keycode == 0x7f) {
obuf[0] = 0x7f;
obuf[1] = 0x7f;
- olen = 2;
} else {
obuf[0] = keycode;
/* NOTE: the power key key-up is the two byte sequence 0xff 0xff;
@@ -224,10 +221,9 @@ static int adb_kbd_poll(ADBDevice *d, uint8_t *obuf)
* byte, but choose not to bother.
*/
obuf[1] = 0xff;
- olen = 2;
}
- return olen;
+ return 2;
}
static int adb_kbd_request(ADBDevice *d, uint8_t *obuf,
--
2.21.1
- [PATCH v3 0/9] misc: Trivial static code analyzer fixes, Philippe Mathieu-Daudé, 2020/04/22
- [PATCH v3 2/9] blockdev: Remove dead assignment, Philippe Mathieu-Daudé, 2020/04/22
- [PATCH v3 1/9] block: Avoid dead assignment, Philippe Mathieu-Daudé, 2020/04/22
- [PATCH v3 4/9] hw/input/adb-kbd: Remove dead assignment,
Philippe Mathieu-Daudé <=
- [PATCH v3 3/9] hw/i2c/pm_smbus: Remove dead assignment, Philippe Mathieu-Daudé, 2020/04/22
- [PATCH v3 5/9] hw/ide/sii3112: Remove dead assignment, Philippe Mathieu-Daudé, 2020/04/22
- [PATCH v3 6/9] hw/isa/i82378: Remove dead assignment, Philippe Mathieu-Daudé, 2020/04/22
- [PATCH v3 7/9] hw/gpio/aspeed_gpio: Remove dead assignment, Philippe Mathieu-Daudé, 2020/04/22
- [PATCH v3 9/9] hw/timer/pxa2xx_timer: Add assertion to silent static analyzer warning, Philippe Mathieu-Daudé, 2020/04/22
- [PATCH v3 8/9] hw/timer/stm32f2xx_timer: Remove dead assignment, Philippe Mathieu-Daudé, 2020/04/22