[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] elf_ops: Don't try to g_mapped_file_unref(NULL)

From: Peter Maydell
Subject: Re: [PATCH] elf_ops: Don't try to g_mapped_file_unref(NULL)
Date: Thu, 23 Apr 2020 21:47:38 +0100

On Thu, 23 Apr 2020 at 21:25, Philippe Mathieu-Daudé <address@hidden> wrote:
> On 4/23/20 10:20 PM, Peter Maydell wrote:
> > This will fix the assertion; for the specific case of the generic
> > loader it will then fall back from "guess this is an ELF file" to
> > "maybe it's a uImage or a hex file" and eventually to "just load as
> > a raw data file".

> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

Thanks; as a side note "let me just load this as a raw data file"
is not a very user-friendly way to report issues with the ELF
file like "seems to be truncated" or "has no program headers".
Not sure what to do about that...

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]