[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v2 17/19] hw/gpio/aspeed_gpio: Remove dead assignment
From: |
Laurent Vivier |
Subject: |
[PULL v2 17/19] hw/gpio/aspeed_gpio: Remove dead assignment |
Date: |
Mon, 4 May 2020 17:59:54 +0200 |
From: Philippe Mathieu-Daudé <address@hidden>
Fix warning reported by Clang static code analyzer:
hw/gpio/aspeed_gpio.c:717:18: warning: Value stored to 'g_idx' during its
initialization is never read
int set_idx, g_idx = *group_idx;
^~~~~ ~~~~~~~~~~
Reported-by: Clang Static Analyzer
Reviewed-by: Cédric Le Goater <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
---
hw/gpio/aspeed_gpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/gpio/aspeed_gpio.c b/hw/gpio/aspeed_gpio.c
index e52fcfd9a030..4c75b5c80cc9 100644
--- a/hw/gpio/aspeed_gpio.c
+++ b/hw/gpio/aspeed_gpio.c
@@ -712,7 +712,7 @@ static void aspeed_gpio_write(void *opaque, hwaddr offset,
uint64_t data,
static int get_set_idx(AspeedGPIOState *s, const char *group, int *group_idx)
{
AspeedGPIOClass *agc = ASPEED_GPIO_GET_CLASS(s);
- int set_idx, g_idx = *group_idx;
+ int set_idx, g_idx;
for (set_idx = 0; set_idx < agc->nr_gpio_sets; set_idx++) {
const GPIOSetProperties *set_props = &agc->props[set_idx];
--
2.26.2
- [PULL v2 04/19] MAINTAINERS: Mark the LatticeMico32 target as orphan, (continued)
- [PULL v2 04/19] MAINTAINERS: Mark the LatticeMico32 target as orphan, Laurent Vivier, 2020/05/04
- [PULL v2 02/19] display/blizzard: use extract16() for fix clang analyzer warning in blizzard_draw_line16_32(), Laurent Vivier, 2020/05/04
- [PULL v2 07/19] elf_ops: Don't try to g_mapped_file_unref(NULL), Laurent Vivier, 2020/05/04
- [PULL v2 08/19] MAINTAINERS: Update Keith Busch's email address, Laurent Vivier, 2020/05/04
- [PULL v2 03/19] timer/exynos4210_mct: Remove redundant statement in exynos4210_mct_write(), Laurent Vivier, 2020/05/04
- [PULL v2 12/19] blockdev: Remove dead assignment, Laurent Vivier, 2020/05/04
- [PULL v2 01/19] scsi/esp-pci: add g_assert() for fix clang analyzer warning in esp_pci_io_write(), Laurent Vivier, 2020/05/04
- [PULL v2 10/19] Compress lines for immediate return, Laurent Vivier, 2020/05/04
- [PULL v2 09/19] chardev: Add macOS to list of OSes that support -chardev serial, Laurent Vivier, 2020/05/04
- [PULL v2 13/19] hw/i2c/pm_smbus: Remove dead assignment, Laurent Vivier, 2020/05/04
- [PULL v2 17/19] hw/gpio/aspeed_gpio: Remove dead assignment,
Laurent Vivier <=
- [PULL v2 19/19] hw/timer/pxa2xx_timer: Add assertion to silent static analyzer warning, Laurent Vivier, 2020/05/04
- [PULL v2 15/19] hw/ide/sii3112: Remove dead assignment, Laurent Vivier, 2020/05/04
- [PULL v2 11/19] block: Avoid dead assignment, Laurent Vivier, 2020/05/04
- [PULL v2 14/19] hw/input/adb-kbd: Remove dead assignment, Laurent Vivier, 2020/05/04
- [PULL v2 16/19] hw/isa/i82378: Remove dead assignment, Laurent Vivier, 2020/05/04
- [PULL v2 18/19] hw/timer/stm32f2xx_timer: Remove dead assignment, Laurent Vivier, 2020/05/04
- Re: [PULL v2 00/19] Trivial branch for 5.1 patches, Peter Maydell, 2020/05/05