[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/openrisc/openrisc_sim: Add assertion to silent GCC warnin
From: |
Stafford Horne |
Subject: |
Re: [PATCH] hw/openrisc/openrisc_sim: Add assertion to silent GCC warning |
Date: |
Wed, 10 Jun 2020 05:42:27 +0900 |
On Mon, Jun 08, 2020 at 10:33:24AM -0500, Eric Blake wrote:
> On 6/8/20 2:14 AM, Philippe Mathieu-Daudé wrote:
> > When compiling with GCC 10 (Fedora 32) using CFLAGS=-O2 we get:
>
> In the subject: s/silent/silence/
>
> >
> > CC or1k-softmmu/hw/openrisc/openrisc_sim.o
> > hw/openrisc/openrisc_sim.c: In function ‘openrisc_sim_init’:
> > hw/openrisc/openrisc_sim.c:87:42: error: ‘cpu_irqs[0]’ may be used
> > uninitialized in this function [-Werror=maybe-uninitialized]
> > 87 | sysbus_connect_irq(s, i, cpu_irqs[i][irq_pin]);
> > | ~~~~~~~~^~~
> >
> > While humans can tell smp_cpus will always be in the [1, 2] range,
> > (openrisc_sim_machine_init sets mc->max_cpus = 2), the compiler
> > can't.
> >
> > Add an assertion to give the compiler a hint there's no use of
> > uninitialized data.
> >
> > Buglink: https://bugs.launchpad.net/qemu/+bug/1874073
> > Reported-by: Martin Liška <mliska@suse.cz>
> > Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> > ---
> > hw/openrisc/openrisc_sim.c | 1 +
> > 1 file changed, 1 insertion(+)
>
> Tested-by: Eric Blake <eblake@redhat.com>
>
> With the typo fixed,
> Reviewed-by: Eric Blake <eblake@redhat.com>
Acked-by: Stafford Horne <shorne@gmail.com>
I see there are now two patches for this, I kind of like this assert fix.
Shall I queue it for OpenRISC pulling? Or can someone else pick this up?
-Stafford