[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 1/7] MAINTAINERS: Cover 'hw/sh4/sh_intc.h' with the R2D ma
From: |
Thomas Huth |
Subject: |
Re: [PATCH v4 1/7] MAINTAINERS: Cover 'hw/sh4/sh_intc.h' with the R2D machine |
Date: |
Tue, 16 Jun 2020 17:56:27 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 16/06/2020 16.49, Philippe Mathieu-Daudé wrote:
> On 6/16/20 3:34 PM, Thomas Huth wrote:
>> On 11/06/2020 13.43, Philippe Mathieu-Daudé wrote:
>>> Commit 81527b94ad added hw/intc/sh_intc.c, complete by
>>> adding its corresponding header.
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>> ---
>>> MAINTAINERS | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index 13711aafe8..87ceca7ff1 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -1257,6 +1257,7 @@ S: Maintained
>>> F: hw/sh4/r2d.c
>>> F: hw/intc/sh_intc.c
>>> F: hw/timer/sh_timer.c
>>> +F: include/hw/sh4/sh_intc.h
>>>
>>> Shix
>>> M: Yoshinori Sato <ysato@users.sourceforge.jp>
>>
>> Hmm, sh_intc.h is used by sh7750_init() in sh7750.c ... and that
>> function is used by both, r2d and shix machines ... so should that maybe
>> rather be part of both machines or a generic entry?
>
> I'll add it to both machines. The maintainers can reorder
> the sections later.
>
> Thanks for the review!
Ok, with that change:
Reviewed-by: Thomas Huth <thuth@redhat.com>
- [PATCH v4 0/7] sh4: Add 'Renesas peripherals' entry in MAINTAINERS + trivial fixes, Philippe Mathieu-Daudé, 2020/06/11
- [PATCH v4 2/7] MAINTAINERS: Add an entry for common Renesas peripherals, Philippe Mathieu-Daudé, 2020/06/11
- [PATCH v4 3/7] hw/sh4: Use MemoryRegion typedef, Philippe Mathieu-Daudé, 2020/06/11
- [PATCH v4 4/7] hw/sh4: Extract timer definitions to 'hw/timer/tmu012.h', Philippe Mathieu-Daudé, 2020/06/11
- [PATCH v4 5/7] hw/timer/sh_timer: Remove unused 'qemu/timer.h' include, Philippe Mathieu-Daudé, 2020/06/11
- [PATCH v4 6/7] tests/acceptance: Add boot tests for sh4 QEMU advent calendar image, Philippe Mathieu-Daudé, 2020/06/11
- [PATCH v4 7/7] .travis.yml: Test SH4 QEMU advent calendar image, Philippe Mathieu-Daudé, 2020/06/11