Re: [PATCH] disas/sh4: Add missing fallthrough annotations

[no-reply]

Patchew URL: 20200630055953.9309-1-thuth@redhat.com/">https://patchew.org/QEMU/20200630055953.9309-1-thuth@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH] disas/sh4: Add missing fallthrough annotations
Type: series
Message-id: 20200630055953.9309-1-thuth@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   e765115..fc1bff9  master     -> master
 - [tag update]      patchew/20200629173821.22037-1-f4bug@amsat.org -> 
patchew/20200629173821.22037-1-f4bug@amsat.org
 * [new tag]         patchew/20200630055953.9309-1-thuth@redhat.com -> 
patchew/20200630055953.9309-1-thuth@redhat.com
Switched to a new branch 'test'
82643b9 disas/sh4: Add missing fallthrough annotations

=== OUTPUT BEGIN ===
ERROR: code indent should never use tabs
#23: FILE: disas/sh4.c:1966:
+^I      /* fallthrough */$

ERROR: code indent should never use tabs
#31: FILE: disas/sh4.c:1976:
+^I      /* fallthrough */$

total: 2 errors, 0 warnings, 14 lines checked

Commit 82643b95d2e7 (disas/sh4: Add missing fallthrough annotations) has style 
problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20200630055953.9309-1-thuth@redhat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20200630055953.9309-1-thuth@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com