[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/9] Enabling BSD symbols

From: Eric Blake
Subject: Re: [PATCH 1/9] Enabling BSD symbols
Date: Wed, 1 Jul 2020 08:58:51 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0

On 6/29/20 4:48 PM, David CARLIER wrote:
From 5c6022f21289eb6e78e93d584c766db82165dced Mon Sep 17 00:00:00 2001
From: David Carlier <devnexen@gmail.com>
Date: Mon, 29 Jun 2020 22:13:35 +0000
Subject: [PATCH 1/9] Enabling BSD symbols.

Suggestion for the title:

build: Enable BSD symbols for Haiku

Rationale for that suggestion: most commits start with a category (here, 'build:' is a nice catch-all, since you are improving the build for a given platform). We tend to avoid trailing '.' in the subject. And mentioning which platform is affected is useful for someone browsing one-line summaries to know the scope of theh change.

Also, this message (and the rest of the series) came through as a top-level thread, rather than in-reply-to the 0/9 message. That makes it harder to track the changes as a group.

Signed-off-by: David Carlier <devnexen@gmail.com>
  configure | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure b/configure
index 4a22dcd563..d81931ba5e 100755
--- a/configure
+++ b/configure
@@ -903,8 +903,8 @@ SunOS)
-  LIBS="-lposix_error_mapper -lnetwork $LIBS"
+  LIBS="-lposix_error_mapper -lnetwork -lbsd $LIBS"
    audio_drv_list="try-pa oss"

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]