[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix MIPS add.s after 1ace099f2acb952eaaef0ba7725879949a7e440

From: Aleksandar Markovic
Subject: Re: [PATCH] Fix MIPS add.s after 1ace099f2acb952eaaef0ba7725879949a7e4406
Date: Fri, 3 Jul 2020 18:33:52 +0200

On Friday, July 3, 2020, Alex Richardson <Alexander.Richardson@cl.cam.ac.uk> wrote:
After merging latest QEMU upstream into our CHERI fork, I noticed that
some of the FPU tests in our MIPS baremetal testsuite
(https://github.com/CTSRD-CHERI/cheritest) started failing. It turns out
this commit accidentally changed add.s into a subtract.

Alex, all you said sounds very probable to me. I currently don't have any dev system, at hand, but as soon as I get it, I will confirm/disconfirm (but again, most likely confirm) this problem, and than we'll give you green lifght for your patch.


Signed-off-by: Alex Richardson <Alexander.Richardson@cl.cam.ac.uk>
 target/mips/fpu_helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/mips/fpu_helper.c b/target/mips/fpu_helper.c
index 7a3a61cab3..56beda49d8 100644
--- a/target/mips/fpu_helper.c
+++ b/target/mips/fpu_helper.c
@@ -1221,7 +1221,7 @@ uint32_t helper_float_add_s(CPUMIPSState *env,
     uint32_t wt2;

-    wt2 = float32_sub(fst0, fst1, &env->active_fpu.fp_status);
+    wt2 = float32_add(fst0, fst1, &env->active_fpu.fp_status);
     update_fcr31(env, GETPC());
     return wt2;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]