[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] target/nios2: Use gen_io_start around wrctl instruction
From: |
Max Filippov |
Subject: |
Re: [PATCH 3/3] target/nios2: Use gen_io_start around wrctl instruction |
Date: |
Sun, 5 Jul 2020 13:53:59 -0700 |
On Sun, Jul 5, 2020 at 11:16 AM Max Filippov <jcmvbkbc@gmail.com> wrote:
> On Sun, Jul 5, 2020 at 10:09 AM Peter Maydell <peter.maydell@linaro.org>
> wrote:
> > On Thu, 2 Jul 2020 at 19:53, Richard Henderson
> > <richard.henderson@linaro.org> wrote:
> > > This isn't right. Not so much the gen_io_start portion, but the entire
> > > existence of helper_check_interrupt.
> > I agree that it looks bogus (xtensa has a similar helper as well,
> > incidentally),
> I think there was a reason for it.
...and the reason is that this helper calls cpu_[re]set_interrupt
to update CPU_INTERRUPT_HARD, which makes exit to the
main CPU loop do something to handle IRQ.
Maybe 'check_interrupt' is not a good name for that, but the
action taken there seems right to me.
--
Thanks.
-- Max
- RE: [PATCH 3/3] target/nios2: Use gen_io_start around wrctl instruction, Wu, Wentong, 2020/07/01
- Re: [PATCH 3/3] target/nios2: Use gen_io_start around wrctl instruction, Richard Henderson, 2020/07/02
- RE: [PATCH 3/3] target/nios2: Use gen_io_start around wrctl instruction, Wu, Wentong, 2020/07/03
- RE: [PATCH 3/3] target/nios2: Use gen_io_start around wrctl instruction, Wu, Wentong, 2020/07/05
- RE: [PATCH 3/3] target/nios2: Use gen_io_start around wrctl instruction, Wu, Wentong, 2020/07/05
- Re: [PATCH 3/3] target/nios2: Use gen_io_start around wrctl instruction, Peter Maydell, 2020/07/05
- RE: [PATCH 3/3] target/nios2: Use gen_io_start around wrctl instruction, Wu, Wentong, 2020/07/05
RE: [PATCH 3/3] target/nios2: Use gen_io_start around wrctl instruction, Wu, Wentong, 2020/07/03
Re: [PATCH 3/3] target/nios2: Use gen_io_start around wrctl instruction, Peter Maydell, 2020/07/05