[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] scripts: improve message when TAP based tests fail
From: |
Paolo Bonzini |
Subject: |
Re: [PATCH] scripts: improve message when TAP based tests fail |
Date: |
Mon, 6 Jul 2020 15:17:51 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 06/07/20 14:50, Daniel P. Berrangé wrote:
> If one of the qtests fails, the TAP driver prints out a message like:
>
> ERROR - too few tests run (expected 3, got 1)
>
> which fails to tell you which test program failed. This is a critical
> ommission when many tests are running in parallel as their output is
> interleaved. The improved message is:
>
> ERROR endianness-test - too few tests run (expected 3, got 1)
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> scripts/tap-driver.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/tap-driver.pl b/scripts/tap-driver.pl
> index 6621a5cd67..b1d3880c50 100755
> --- a/scripts/tap-driver.pl
> +++ b/scripts/tap-driver.pl
> @@ -217,7 +217,7 @@ sub report ($;$)
>
> sub testsuite_error ($)
> {
> - report "ERROR", "- $_[0]";
> + report "ERROR", "$test_name - $_[0]";
> }
>
> sub handle_tap_result ($)
>
Queued, thanks.
Paolo