Re: [PATCH 04/12] scsi: Remove superfluous breaks

[Thomas Huth]

On 13/07/2020 11.04, Yi Wang wrote:
> From: Liao Pingfang <liao.pingfang@zte.com.cn>
> 
> Remove superfluous breaks, as there is a "return" before them.
> 
> Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> 
> ---
>  scsi/utils.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/scsi/utils.c b/scsi/utils.c
> index c50e81f..b37c283 100644
> --- a/scsi/utils.c
> +++ b/scsi/utils.c
> @@ -32,17 +32,13 @@ uint32_t scsi_cdb_xfer(uint8_t *buf)
>      switch (buf[0] >> 5) {
>      case 0:
>          return buf[4];
> -        break;
>      case 1:
>      case 2:
>          return lduw_be_p(&buf[7]);
> -        break;
>      case 4:
>          return ldl_be_p(&buf[10]) & 0xffffffffULL;
> -        break;
>      case 5:
>          return ldl_be_p(&buf[6]) & 0xffffffffULL;
> -        break;
>      default:
>          return -1;
>      }
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>