Re: [PATCH] target/unicore32: Remove CURSES stuff from the Makefile.objs

[Thomas Huth]

On 23/07/2020 16.50, Peter Maydell wrote:
> On Thu, 23 Jul 2020 at 14:23, Thomas Huth <thuth@redhat.com> wrote:
>>
>> The dependency on curses has been removed in commit c7a856b42e403e2b
>> ("target/unicore32: Prefer qemu_semihosting_log_out() over curses").
>> So we can remove the related lines in the Makefile now, too.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
> 
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> 
> Another, unrelated, CONFIG_CURSES oddity:
> hw/input/virtio-input-hid.c has an "#undef CONFIG_CURSES"
> before it includes ui/console.h. But that header file
> doesn't do anything different if CONFIG_CURSES is defined,
> so I think the undef is now useless and can be removed.

There used to be some curses stuff in that header, but it has been
removed more than two years ago (see commit b0766612d16da18). So yes, I
think you're right, that #undef CONFIG_CURSES can be removed now. Care
to send a patch?

 Thomas