Re: [PATCH-for-5.2] default-configs: Remove ACPI_CPU_HOTPLUG from MIPS machines

[Philippe Mathieu-Daudé]

On 7/30/20 1:34 PM, Igor Mammedov wrote:
> On Fri, 24 Jul 2020 18:52:59 +0200
> Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> 
>> No MIPS machine uses the ACPI cpu-hotplug feature
>> (QEMU implementation is X86 specific).
> 
> if I recall correctly we were building it to satisfy symbol dependencies
> due to hw/acpi/piix4.c being shared between x86 and mips.
> 
> It no longer the case?

Unfortunately you are right, it is still the case :(

> 
> 
>> Fixes: 135a67a692 ("ACPI: split CONFIG_ACPI into 4 pieces")
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>>  default-configs/mips-softmmu-common.mak | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/default-configs/mips-softmmu-common.mak 
>> b/default-configs/mips-softmmu-common.mak
>> index da29c6c0b2..e9c208da3d 100644
>> --- a/default-configs/mips-softmmu-common.mak
>> +++ b/default-configs/mips-softmmu-common.mak
>> @@ -21,7 +21,6 @@ CONFIG_ACPI=y
>>  CONFIG_ACPI_X86=y
>>  CONFIG_ACPI_MEMORY_HOTPLUG=y
>>  CONFIG_ACPI_NVDIMM=y
>> -CONFIG_ACPI_CPU_HOTPLUG=y
>>  CONFIG_APM=y
>>  CONFIG_I8257=y
>>  CONFIG_PIIX4=y
> 
>