[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 10/10] hw/display/vga:Remove redundant statement in vga_dr
From: |
Laurent Vivier |
Subject: |
Re: [PATCH v3 10/10] hw/display/vga:Remove redundant statement in vga_draw_graphic() |
Date: |
Tue, 1 Sep 2020 12:06:44 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
Le 27/08/2020 à 13:03, Chen Qun a écrit :
> Clang static code analyzer show warning:
> hw/display/vga.c:1677:9: warning: Value stored to 'update' is never read
> update = full_update;
> ^ ~~~~~~~~~~~
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
> Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
> Reviewed-by: Li Qiang <liq3ea@gmail.com>
> ---
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> ---
> hw/display/vga.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/display/vga.c b/hw/display/vga.c
> index 061fd9ab8f..836ad50c7b 100644
> --- a/hw/display/vga.c
> +++ b/hw/display/vga.c
> @@ -1674,7 +1674,6 @@ static void vga_draw_graphic(VGACommonState *s, int
> full_update)
> if (!(s->cr[VGA_CRTC_MODE] & 2)) {
> addr = (addr & ~0x8000) | ((y1 & 2) << 14);
> }
> - update = full_update;
> page0 = addr & s->vbe_size_mask;
> page1 = (addr + bwidth - 1) & s->vbe_size_mask;
> if (full_update) {
>
Applied to my trivial-patches branch.
Thanks,
Laurent
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v3 10/10] hw/display/vga:Remove redundant statement in vga_draw_graphic(),
Laurent Vivier <=