[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 01/18] hw/mips/fuloong2e: Convert pointless error message to an as
From: |
Laurent Vivier |
Subject: |
[PULL 01/18] hw/mips/fuloong2e: Convert pointless error message to an assert() |
Date: |
Fri, 11 Sep 2020 21:33:13 +0200 |
From: Philippe Mathieu-Daudé <f4bug@amsat.org>
Displaying "vt82c686b_init error" doesn't give any hint about why
this call failed. As this message targets developers and not users,
replace the pointless error message by a call to assert() which
will provide more useful information.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Huacai Chen <chenhc@lemote.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200901104043.91383-3-f4bug@amsat.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
hw/mips/fuloong2e.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/hw/mips/fuloong2e.c b/hw/mips/fuloong2e.c
index 8ca31e5162c4..f28609976bf4 100644
--- a/hw/mips/fuloong2e.c
+++ b/hw/mips/fuloong2e.c
@@ -240,10 +240,7 @@ static void vt82c686b_southbridge_init(PCIBus *pci_bus,
int slot, qemu_irq intc,
PCIDevice *dev;
isa_bus = vt82c686b_isa_init(pci_bus, PCI_DEVFN(slot, 0));
- if (!isa_bus) {
- fprintf(stderr, "vt82c686b_init error\n");
- exit(1);
- }
+ assert(isa_bus);
*p_isa_bus = isa_bus;
/* Interrupt controller */
/* The 8259 -> IP5 */
--
2.26.2
- [PULL 00/18] Trivial branch for 5.2 patches, Laurent Vivier, 2020/09/11
- [PULL 02/18] hw/isa/isa-bus: Replace hw_error() by assert(), Laurent Vivier, 2020/09/11
- [PULL 04/18] hw/gpio/omap_gpio: Replace fprintf() by qemu_log_mask(GUEST_ERROR), Laurent Vivier, 2020/09/11
- [PULL 03/18] hw/acpi/tco: Remove unused definitions, Laurent Vivier, 2020/09/11
- [PULL 05/18] hw/gpio/max7310: Replace disabled printf() by qemu_log_mask(UNIMP), Laurent Vivier, 2020/09/11
- [PULL 06/18] Makefile: Drop extra phony cscope, Laurent Vivier, 2020/09/11
- [PULL 01/18] hw/mips/fuloong2e: Convert pointless error message to an assert(),
Laurent Vivier <=
- [PULL 08/18] hw/net/e1000e: Remove overwritten read handler for STATUS register, Laurent Vivier, 2020/09/11
- [PULL 07/18] Makefile: Skip the meson subdir in cscope/TAGS/ctags, Laurent Vivier, 2020/09/11
- [PULL 09/18] hw/net/e1000e: Remove duplicated write handler for FLSWDATA register, Laurent Vivier, 2020/09/11
- [PULL 11/18] kconfig: fix comment referring to old Makefiles, Laurent Vivier, 2020/09/11
- [PULL 14/18] target/i386/kvm: Rename host_tsx_blacklisted() as host_tsx_broken(), Laurent Vivier, 2020/09/11
- [PULL 12/18] hw: hyperv: vmbus: Fix 32bit compilation, Laurent Vivier, 2020/09/11
- [PULL 15/18] hw/arm/pxa2xx: Add missing fallthrough comment, Laurent Vivier, 2020/09/11
- [PULL 18/18] target/i386/kvm: Add missing fallthrough comment, Laurent Vivier, 2020/09/11
- [PULL 13/18] test-vmstate: remove unnecessary code in match_interval_mapping_node, Laurent Vivier, 2020/09/11
- [PULL 10/18] meson.build: tweak sdl-image error message, Laurent Vivier, 2020/09/11