|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [PATCH] hw/core/qdev-properties: Fix pci bus range in set_pci_host_devaddr() |
Date: | Tue, 13 Oct 2020 10:34:09 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 |
Hi Klaus, On 10/13/20 12:58 AM, Klaus Herman wrote: Please include:Fixes: bccb20c49df ("hw/core/qdev-properties: Use qemu_strtoul() in set_pci_host_devaddr()")
You forgot to sign your patch, see: https://wiki.qemu.org/Contribute/SubmitAPatch#Patch_emails_must_include_a_Signed-off-by:_line
--- hw/core/qdev-properties-system.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-system.c index 49bdd12..e3dca56 100644 --- a/hw/core/qdev-properties-system.c +++ b/hw/core/qdev-properties-system.c @@ -903,7 +903,7 @@ static void set_pci_host_devaddr(Object *obj, Visitor *v, const char *name, bus = val;p = (char *)e + 1;- if (qemu_strtoul(p, &e, 16, &val) < 0 || val > 0x1f || e == p) { + if (qemu_strtoul(p, &e, 16, &val) < 0 || val > 0xff || e == p) { goto inval; } if (*e == ':') {
[Prev in Thread] | Current Thread | [Next in Thread] |