[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/virtio-pci: Replace error_report() by qemu_log_mask(GUEST
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH] hw/virtio-pci: Replace error_report() by qemu_log_mask(GUEST_ERROR) |
|
Date: |
Fri, 8 Jan 2021 16:00:21 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 1/8/21 1:02 PM, Stefano Garzarella wrote:
> On Thu, Dec 10, 2020 at 06:28:34PM +0100, Philippe Mathieu-Daudé wrote:
>> Replace I/O write error reported with error_report() by
>> qemu_log_mask(GUEST_ERROR) which allow filtering.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> hw/virtio/virtio-pci.c | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
>> index f863f69ede4..094c36aa3ea 100644
>> --- a/hw/virtio/virtio-pci.c
>> +++ b/hw/virtio/virtio-pci.c
>> @@ -27,6 +27,7 @@
>> #include "hw/qdev-properties.h"
>> #include "qapi/error.h"
>> #include "qemu/error-report.h"
> ^
> Just a little thing, could we remove this inclusion since we are not
> using error_report() anymore in this file?
We can't because virtio_pci_device_plugged() calls
warn_report() twice :/
> Anyway the patch LGTM:
>
> Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Thanks!
Phil.