[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 9/9] util/guest-random: Fix size arg to tail memcpy
From: |
Laurent Vivier |
Subject: |
[PULL 9/9] util/guest-random: Fix size arg to tail memcpy |
Date: |
Fri, 9 Jul 2021 22:28:24 +0200 |
From: Mark Nelson <mdnelson8@gmail.com>
We know that in the body of this if statement i is less than len, so
we really should be copying len - i bytes not i - len bytes.
Fix this typo.
Fixes: 8d8404f1564 ("util: Add qemu_guest_getrandom and associated routines")
Signed-off-by: Mark Nelson <mdnelson8@gmail.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210709120600.11080-1-mdnelson8@gmail.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
util/guest-random.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/guest-random.c b/util/guest-random.c
index 086115bd6702..23643f86cc60 100644
--- a/util/guest-random.c
+++ b/util/guest-random.c
@@ -38,7 +38,7 @@ static int glib_random_bytes(void *buf, size_t len)
}
if (i < len) {
x = g_rand_int(rand);
- __builtin_memcpy(buf + i, &x, i - len);
+ __builtin_memcpy(buf + i, &x, len - i);
}
return 0;
}
--
2.31.1
- [PULL 0/9] Trivial branch for 6.1 patches, Laurent Vivier, 2021/07/09
- [PULL 1/9] qemu-option: Drop dead assertion, Laurent Vivier, 2021/07/09
- [PULL 6/9] hw/virtio: Document *_should_notify() are called within rcu_read_lock(), Laurent Vivier, 2021/07/09
- [PULL 2/9] memory: Display MemoryRegion name in read/write ops trace events, Laurent Vivier, 2021/07/09
- [PULL 8/9] migration: fix typo in mig_throttle_guest_down comment, Laurent Vivier, 2021/07/09
- [PULL 4/9] virtiofsd: Add missing newline in error message, Laurent Vivier, 2021/07/09
- [PULL 5/9] misc: Remove redundant new line in perror(), Laurent Vivier, 2021/07/09
- [PULL 9/9] util/guest-random: Fix size arg to tail memcpy,
Laurent Vivier <=
- [PULL 7/9] target/xtensa/xtensa-semi: Fix compilation problem on Haiku, Laurent Vivier, 2021/07/09
- [PULL 3/9] misc: Fix "havn't" typo, Laurent Vivier, 2021/07/09
- Re: [PULL 0/9] Trivial branch for 6.1 patches, Peter Maydell, 2021/07/11