[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] qdev: Complete qdev_init_gpio_out() documentation
From: |
Markus Armbruster |
Subject: |
Re: [PATCH] qdev: Complete qdev_init_gpio_out() documentation |
Date: |
Wed, 01 Sep 2021 13:19:29 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Cc: qemu-trivial
Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> qdev_init_gpio_out() states it "creates an array of anonymous
> output GPIO lines" but doesn't document how this array is
> released. Add a note that it is automatically free'd in qdev
> instance_finalize().
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> include/hw/qdev-core.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h
> index bafc311bfa1..555d4e444a5 100644
> --- a/include/hw/qdev-core.h
> +++ b/include/hw/qdev-core.h
> @@ -597,6 +597,10 @@ void qdev_init_gpio_in(DeviceState *dev,
> qemu_irq_handler handler, int n);
> *
> * See qdev_connect_gpio_out() for how code that uses such a device
> * can connect to one of its output GPIO lines.
> + *
> + * There is no need to release the @pins allocated array because it
> + * will be automatically released when @dev calls its instance_finalize()
> + * handler.
> */
> void qdev_init_gpio_out(DeviceState *dev, qemu_irq *pins, int n);
> /**
- Re: [PATCH] qdev: Complete qdev_init_gpio_out() documentation,
Markus Armbruster <=